Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have control interface use less stack #100

Closed
m-ronnblom opened this issue Oct 18, 2024 · 0 comments
Closed

Have control interface use less stack #100

m-ronnblom opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@m-ronnblom
Copy link
Collaborator

The libxcm control interface (libxcm/ctl.c) uses ~38 kb stack, which may cause issues if the calling thread has a tiny stack configured.

It should be possible to peek on the control fd to see if data is available, and in that case do a 38 kb short-lived heap allocation. However this "peeking" should be efficient (as fast as recv() or faster), since the process_client() functions is run often (as long as a client is connected).

@m-ronnblom m-ronnblom added the enhancement New feature or request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant