Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Mistral.rs with Swiftide #843

Open
timonv opened this issue Oct 12, 2024 · 3 comments
Open

Integrating Mistral.rs with Swiftide #843

timonv opened this issue Oct 12, 2024 · 3 comments

Comments

@timonv
Copy link

timonv commented Oct 12, 2024

Hey there,

Figured I'd give it another shot to integrate mistral.rs with Swiftide. Tested several text models and it works great. Kudos on the new v4 builder style api, it's very clean 👍

However, github actions is now running into limitations and kills the worker with a 143 (afaik this is usually due to high cpu).

I've been looking at cargo timings and tried some tuning, but no luck so far. Does mistral.rs have to do tuning to be able to run in GA? I couldn't find anything specific. The full PR is at bosun-ai/swiftide#386

Side note: Would it be possible to publish mistralrs as a crate?

@timonv
Copy link
Author

timonv commented Oct 27, 2024

@EricLBuehler With a bit of tuning builds are working reliably and the integration is pretty cool bosun-ai/swiftide#421. However, crates.io does not allow publishing crates that rely on unpublished crates. Is there a reason mistral.rs is not published on crates.io? release-plz makes the process rather painless.

@EricLBuehler
Copy link
Owner

Hi @timonv! Just released v0.3.4 which integrates some nice changes. We have a fork of Candle which I don't want to publish as it'll conflict with the base Candle package. Otherwise, I would absolutely do so.

@timonv
Copy link
Author

timonv commented Nov 28, 2024

Hey @EricLBuehler, thanks for reaching out. After some tinkering, I got it to work fine in a pipeline as well.

Besides having erics-candle, is there no way to up stream the changes or extend? I'm not familiar with the candle internals 🤷

Otherwise, I'll probably go for a separate swiftide-mistrals that users can add as a git dependency instead. It's hard to gauche the traction, it got asked for multiple times, but then people stopped asking. So when/if really depends on if that resumes again.

6x is insane! Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants