Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE][v13+] Actor/Item Sheet rework #802

Open
6 tasks
BoltsJ opened this issue Nov 29, 2024 · 0 comments
Open
6 tasks

[FEATURE][v13+] Actor/Item Sheet rework #802

BoltsJ opened this issue Nov 29, 2024 · 0 comments
Labels
feature New feature or request refactor Refactors of the code base for API changes, maintainability, etc... sheet Issue with actor or item sheets
Milestone

Comments

@BoltsJ
Copy link
Collaborator

BoltsJ commented Nov 29, 2024

V13 officially deprecates Application v1 with v16 being the scheduled removal of application v1. Aside from the appv2 switch over, the sheets are carrying a lot of technical debt and custom redundant solutions. While a conversion would be possible, it would be a lot better to make a clean break and rewrite the sheets underlying code to take advantage tools that foundry provides.

  • Split the headers, tab bars and sheet bodies into separate hbs templates. Foundry provides a stock tab bar template that is easy to restyle to our needs.
  • Remove redundant and unused/under-used helpers. We have a lot of handlebars helpers that replicate helpers already provided by foundry.
  • Utilize formInput and fromGroup helpers to reduce the amount of template code we need to write
  • Utilize modules and nesting in style files to improve organization. Ensure that all styles are namespaced properly to prevent clobbering base foundry styles. Potentially use layers aside from the automatic system layer.
  • Improve effects tab to allow for creation and deletion of custom effects
  • Use built in foundry drag/drop functionality instead of hand-rolled implementation
@BoltsJ BoltsJ added feature New feature or request sheet Issue with actor or item sheets refactor Refactors of the code base for API changes, maintainability, etc... labels Nov 29, 2024
@BoltsJ BoltsJ added this to the Future milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor Refactors of the code base for API changes, maintainability, etc... sheet Issue with actor or item sheets
Projects
None yet
Development

No branches or pull requests

1 participant