chore: Cache random stuff #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wsmoses Do you know if the assumption that the oldest caches get cleaned up holds for the OpenStack runner too? |
I-Al-Istannen
force-pushed
the
chore/cache-random-stuff
branch
from
d7b19a3 to
9676faf
Compare
wsmoses
approved these changes
Apr 19, 2024
|
Yea, the names are pretty much random atm. I first wanted to see whether it helps at all. The Cargo.lock file in |
ZuseZ4
force-pushed
the
chore/cache-random-stuff
branch
from
9676faf to
3986bf1
Compare
|
Going from 18-30 to 3 minutes is an awesome speedup. |
jedbrown
reviewed
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI spends quite some time building the cargo project for the initial stages. The directories added in this PR are marked with the CACHE_DIR flag and therefore cargo should be able to deal with them becoming out of date. I just want to see what, if anything, this can save first. There are a few considerations with cache size one has to think about, as we no longer really have a stable hash to base the cache on. Maybe we could build something from the more internal build files, but that is a problem for later. In the meantime it will just bloat the caches, generating a new one every CI run, and then hoping that GitHub ages them out nicely.