Handle masked reverse mode atomic append #1691
Comments
|
Should be fixed by: #1563 Requires jll bump |
|
Thanks for the quick consideration! Unfortunately, the same error is returned following upgrade to latest version: [[deps.Enzyme]]
deps = ["CEnum", "EnzymeCore", "Enzyme_jll", "GPUCompiler", "LLVM", "Libdl", "LinearAlgebra", "ObjectFile", "Preferences", "Printf", "Random"]
git-tree-sha1 = "4e9d7571ccae47ee15f9ef40f09827323187c022"
repo-rev = "main"
repo-url = "https://github.com/EnzymeAD/Enzyme.jl.git"
uuid = "7da242da-08ed-463a-9acd-ee780be4f1d9"
version = "0.11.10"
[[deps.EnzymeCore]]
deps = ["Adapt"]
git-tree-sha1 = "2efe862de93cd87f620ad6ac9c9e3f83f1b2841b"
uuid = "f151be2c-9106-41f4-ab19-57ee4f262869"
version = "0.6.4"
[[deps.Enzyme_jll]]
deps = ["Artifacts", "JLLWrappers", "LazyArtifacts", "Libdl", "TOML"]
git-tree-sha1 = "fc50e25508991df186a913d96970113fd04ce5f6"
uuid = "7cc45869-7501-5eee-bdea-0790c847d4ef"
version = "0.0.95+0" |
|
A jll is a binary object being imported into Julia. Unfortunately you
cannot update the jll with the Julia package manager so you'll have to wait
for us to bump it (though I did confirm it fixed your code).
…On Tue, Nov 28, 2023 at 7:32 AM jeremiedb ***@***.***> wrote:
Thanks for the quick consideration! Unfortunately, the same error is
returned following upgrade to latest version:
[[deps.Enzyme]]deps = ["CEnum", "EnzymeCore", "Enzyme_jll", "GPUCompiler", "LLVM", "Libdl", "LinearAlgebra", "ObjectFile", "Preferences", "Printf", "Random"]git-tree-sha1 = "4e9d7571ccae47ee15f9ef40f09827323187c022"repo-rev = "main"repo-url = "https://github.com/EnzymeAD/Enzyme.jl.git"uuid = "7da242da-08ed-463a-9acd-ee780be4f1d9"version = "0.11.10"
[[deps.EnzymeCore]]deps = ["Adapt"]git-tree-sha1 = "2efe862de93cd87f620ad6ac9c9e3f83f1b2841b"uuid = "f151be2c-9106-41f4-ab19-57ee4f262869"version = "0.6.4"
[[deps.Enzyme_jll]]deps = ["Artifacts", "JLLWrappers", "LazyArtifacts", "Libdl", "TOML"]git-tree-sha1 = "fc50e25508991df186a913d96970113fd04ce5f6"uuid = "7cc45869-7501-5eee-bdea-0790c847d4ef"version = "0.0.95+0"
—
Reply to this email directly, view it on GitHub
<#1691>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXGDQVM7WTC5G3HR5W3YGWARDAVCNFSM6AAAAAA73NV7QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGE4TSMZYGI>
.
You are receiving this because you commented.Message ID: <EnzymeAD/Enzyme.
***@***.***>
|
|
Are you referring to https://github.com/JuliaBinaryWrappers/Enzyme_jll.jl? |
|
Correct you will need the next jll once it is available. I tagged a new
version of Enzyme with the patch last night, which Yggdrassil will
hopefully make available shortly.
…On Wed, Nov 29, 2023, 8:20 AM jeremiedb ***@***.***> wrote:
Are you referring to https://github.com/JuliaBinaryWrappers/Enzyme_jll.jl?
I noted v0.0.95+0 was released yesterday and I used it in the above test.
Should I look forward v0.0.96+0?
—
Reply to this email directly, view it on GitHub
<#1691>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXD55LAXVG5RPVPSQDTYG3O5HAVCNFSM6AAAAAA73NV7QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZRGM2DKNJXGM>
.
You are receiving this because you commented.Message ID: <EnzymeAD/Enzyme.
***@***.***>
|
|
Jll bump is merged |
|
@wsmoses With Enzyme v0.11.11, the above jeremiedb@client-X570S-AORUS-PRO-AX:~/github/ADTests.jl$ julia --project=@. --threads=2 experiments/conv-v3-lv.jl
julia: /workspace/srcdir/Enzyme/enzyme/Enzyme/DiffeGradientUtils.cpp:931: void DiffeGradientUtils::addToInvertedPtrDiffe(llvm::Instruction*, llvm::Value*, llvm::Type*, unsigned int, unsigned int, llvm::Value*, llvm::Value*, llvm::IRBuilder<>&, llvm::MaybeAlign, llvm::Value*): Assertion `!mask' failed.
[45830] signal (6.-6): Aborted
in expression starting at /home/jeremiedb/github/ADTests.jl/experiments/conv-v3-lv.jl:44
pthread_kill at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
raise at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
abort at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x7f514e8267da)
__assert_fail at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
addToInvertedPtrDiffe at /workspace/srcdir/Enzyme/enzyme/Enzyme/DiffeGradientUtils.cpp:931
addToInvertedPtrDiffe at /workspace/srcdir/Enzyme/enzyme/Enzyme/DiffeGradientUtils.cpp:1231
visitLoadLike at /workspace/srcdir/Enzyme/enzyme/Enzyme/AdjointGenerator.h:687
handleAdjointForIntrinsic at /workspace/srcdir/Enzyme/enzyme/Enzyme/AdjointGenerator.h:3666
visitIntrinsicInst at /workspace/srcdir/Enzyme/enzyme/Enzyme/AdjointGenerator.h:3610
visitDbgInfoIntrinsic at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/InstVisitor.h:208 [inlined]
visitDbgVariableIntrinsic at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/InstVisitor.h:206 [inlined]
visitDbgDeclareInst at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/InstVisitor.h:203 [inlined]
delegateCallInst at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/InstVisitor.h:289 [inlined]
visitCall at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/Instruction.def:209 [inlined]
visit at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/Instruction.def:209
visit at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/InstVisitor.h:111 [inlined]
CreatePrimalAndGradient at /workspace/srcdir/Enzyme/enzyme/Enzyme/EnzymeLogic.cpp:4238
recursivelyHandleSubfunction at /workspace/srcdir/Enzyme/enzyme/Enzyme/AdjointGenerator.h:5664
visitCallInst at /workspace/srcdir/Enzyme/enzyme/Enzyme/AdjointGenerator.h:6286
delegateCallInst at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/InstVisitor.h:301 [inlined]
visitCall at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/Instruction.def:209 [inlined]
visit at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/Instruction.def:209
visit at /opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/IR/InstVisitor.h:111 [inlined]
CreatePrimalAndGradient at /workspace/srcdir/Enzyme/enzyme/Enzyme/EnzymeLogic.cpp:4238
EnzymeCreatePrimalAndGradient at /workspace/srcdir/Enzyme/enzyme/Enzyme/CApi.cpp:582
EnzymeCreatePrimalAndGradient at /home/jeremiedb/.julia/packages/Enzyme/R8qo4/src/api.jl:141
unknown function (ip: 0x7f50ce39342b)
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2892 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
enzyme! at /home/jeremiedb/.julia/packages/Enzyme/R8qo4/src/compiler.jl:3074
unknown function (ip: 0x7f50ce38e0c9)
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2892 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
#codegen#448 at /home/jeremiedb/.julia/packages/Enzyme/R8qo4/src/compiler.jl:4698
codegen at /home/jeremiedb/.julia/packages/Enzyme/R8qo4/src/compiler.jl:4281 [inlined]
_thunk at /home/jeremiedb/.julia/packages/Enzyme/R8qo4/src/compiler.jl:5272
_thunk at /home/jeremiedb/.julia/packages/Enzyme/R8qo4/src/compiler.jl:5272 [inlined]
cached_compilation at /home/jeremiedb/.julia/packages/Enzyme/R8qo4/src/compiler.jl:5306 [inlined]
EnzymeAD/Enzyme.jl#485 at /home/jeremiedb/.julia/packages/Enzyme/R8qo4/src/compiler.jl:5372
JuliaContext at /home/jeremiedb/.julia/packages/GPUCompiler/U36Ed/src/driver.jl:47
unknown function (ip: 0x7f50ce33ca05)
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2892 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
#s1038#484 at /home/jeremiedb/.julia/packages/Enzyme/R8qo4/src/compiler.jl:5324 [inlined]
#s1038#484 at ./none:0
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2892 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
GeneratedFunctionStub at ./boot.jl:600
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2892 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
jl_call_staged at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/method.c:540
ijl_code_for_staged at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/method.c:593
get_staged at ./compiler/utilities.jl:123
retrieve_code_info at ./compiler/utilities.jl:135 [inlined]
InferenceState at ./compiler/inferencestate.jl:430
typeinf_edge at ./compiler/typeinfer.jl:920
abstract_call_method at ./compiler/abstractinterpretation.jl:629
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:95
abstract_call_known at ./compiler/abstractinterpretation.jl:2083
abstract_call at ./compiler/abstractinterpretation.jl:2165
abstract_call at ./compiler/abstractinterpretation.jl:2158
abstract_call at ./compiler/abstractinterpretation.jl:2348
abstract_eval_call at ./compiler/abstractinterpretation.jl:2364
abstract_eval_statement_expr at ./compiler/abstractinterpretation.jl:2374
abstract_eval_statement at ./compiler/abstractinterpretation.jl:2618
abstract_eval_basic_statement at ./compiler/abstractinterpretation.jl:2883
typeinf_local at ./compiler/abstractinterpretation.jl:3092
typeinf_nocycle at ./compiler/abstractinterpretation.jl:3180
_typeinf at ./compiler/typeinfer.jl:247
typeinf at ./compiler/typeinfer.jl:216
typeinf_edge at ./compiler/typeinfer.jl:930
abstract_call_method at ./compiler/abstractinterpretation.jl:629
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:95
abstract_call_known at ./compiler/abstractinterpretation.jl:2083
abstract_call at ./compiler/abstractinterpretation.jl:2165
abstract_apply at ./compiler/abstractinterpretation.jl:1608
abstract_call_known at ./compiler/abstractinterpretation.jl:2000
abstract_call at ./compiler/abstractinterpretation.jl:2165
abstract_call at ./compiler/abstractinterpretation.jl:2158
abstract_call at ./compiler/abstractinterpretation.jl:2348
abstract_eval_call at ./compiler/abstractinterpretation.jl:2364
abstract_eval_statement_expr at ./compiler/abstractinterpretation.jl:2374
abstract_eval_statement at ./compiler/abstractinterpretation.jl:2618
abstract_eval_basic_statement at ./compiler/abstractinterpretation.jl:2907
typeinf_local at ./compiler/abstractinterpretation.jl:3092
typeinf_nocycle at ./compiler/abstractinterpretation.jl:3180
_typeinf at ./compiler/typeinfer.jl:247
typeinf at ./compiler/typeinfer.jl:216
typeinf_edge at ./compiler/typeinfer.jl:930
abstract_call_method at ./compiler/abstractinterpretation.jl:629
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:95
abstract_call_known at ./compiler/abstractinterpretation.jl:2083
abstract_call at ./compiler/abstractinterpretation.jl:2165
abstract_apply at ./compiler/abstractinterpretation.jl:1608
abstract_call_known at ./compiler/abstractinterpretation.jl:2000
abstract_call at ./compiler/abstractinterpretation.jl:2165
abstract_call at ./compiler/abstractinterpretation.jl:2158
abstract_call at ./compiler/abstractinterpretation.jl:2348
abstract_eval_call at ./compiler/abstractinterpretation.jl:2364
abstract_eval_statement_expr at ./compiler/abstractinterpretation.jl:2374
abstract_eval_statement at ./compiler/abstractinterpretation.jl:2618
abstract_eval_basic_statement at ./compiler/abstractinterpretation.jl:2907
typeinf_local at ./compiler/abstractinterpretation.jl:3092
typeinf_nocycle at ./compiler/abstractinterpretation.jl:3180
_typeinf at ./compiler/typeinfer.jl:247
typeinf at ./compiler/typeinfer.jl:216
typeinf_ext at ./compiler/typeinfer.jl:1051
typeinf_ext_toplevel at ./compiler/typeinfer.jl:1082
typeinf_ext_toplevel at ./compiler/typeinfer.jl:1078
jfptr_typeinf_ext_toplevel_35717.1 at /home/jeremiedb/Downloads/julia-1.10.0-rc1/lib/julia/sys.so (unknown line)
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2892 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
jl_apply at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/julia.h:1976 [inlined]
jl_type_infer at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:394
jl_generate_fptr_impl at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/jitlayers.cpp:502
jl_compile_method_internal at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2478 [inlined]
jl_compile_method_internal at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2366
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2884 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
jl_apply at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/julia.h:1976 [inlined]
do_call at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/interpreter.c:125
eval_value at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/interpreter.c:222
eval_stmt_value at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/interpreter.c:173 [inlined]
eval_body at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/interpreter.c:616
jl_interpret_toplevel_thunk at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/interpreter.c:774
jl_toplevel_eval_flex at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/toplevel.c:934
jl_toplevel_eval_flex at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/toplevel.c:877
jl_toplevel_eval_flex at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/toplevel.c:877
ijl_toplevel_eval_in at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/toplevel.c:985
eval at ./boot.jl:383 [inlined]
include_string at ./loading.jl:2070
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2892 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
_include at ./loading.jl:2130
include at ./Base.jl:489
jfptr_include_46395.1 at /home/jeremiedb/Downloads/julia-1.10.0-rc1/lib/julia/sys.so (unknown line)
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2892 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
exec_options at ./client.jl:318
_start at ./client.jl:552
jfptr__start_82758.1 at /home/jeremiedb/Downloads/julia-1.10.0-rc1/lib/julia/sys.so (unknown line)
_jl_invoke at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:2892 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/gf.c:3074
jl_apply at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/julia.h:1976 [inlined]
true_main at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/jlapi.c:582
jl_repl_entrypoint at /cache/build/builder-amdci4-5/julialang/julia-release-1-dot-10/src/jlapi.c:731
main at julia (unknown line)
unknown function (ip: 0x7f514e8280cf)
__libc_start_main at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x4010b8)
Allocations: 30464515 (Pool: 30412228; Big: 52287); GC: 42
Aborted (core dumped) |
|
Upon the next jll bump this error message will now become: |
wsmoses
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following minimal function results in a segfault (run on Enzyme's main as of 2023-11-26, Julia v1.10.0-rc1). If removing the
@turboannotation, the autodiff works fine.Below is the launch command along the resulting error info.
One thing I noticed is the reference to
/opt/x86_64-linux-gnu/x86_64-linux-gnu/sys-root/usr/local/include/llvm/Support/Casting.h:578. Is it expected to point to LLVM under what appears like a general system path raher than a Julia specific one? I'm on Ubuntu 23.10 and Julia was installed in a generic way (untar the official binaries under home directory and creation of sym link).The text was updated successfully, but these errors were encountered: