First pass at SWEET-ENVO cryosphere SSSOM #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for ORCID from Carolyn |
I think this is the last add, so will accept pull shortly
rduerr
previously approved these changes
Dec 19, 2022
|
Looks good, thanks @rduerr ! |
|
Looks decent one small not which would be more in-line with conventions but maybe not necessary would be to use curie for ENVO individually instead of OBO that way the mappings Id lines would look like
I could fix this if we feel its useful. |
cmungall
reviewed
Mar 13, 2023
| obo:ENVO_03400006 lake-effect snowfall sweet:phenAtmoPrecipitation/LakeEffectSnow LakeEffectSnow skos:closeMatch HumanCurated "Candidate Exact match. In SWEET there is a long comment which should be turned into a definition. SWEET talks about snow bands not the snow itself." | ||
| obo:ENVO_03400008 lambing storm sweet:phenAtmoPrecipitation/LambingStorm LambingStorm skos:closeMatch HumanCurated "Candidate Exact match. SWEET needs a definition and depending on what that becomes this could become exact match" | ||
| obo:ENVO_01001547 land ice mass sweet:realmCryo/LandIce LandIce skos:closeMatch HumanCurated "The SWEET definition is limited to the Earth while much of that text is a comment in ENVO and ENVO isn't scoped to the Earth" | ||
| obo:ENVO_00000298 marine iceberg sweet:realmCryo/Iceberg Iceberg skos:closeMatch HumanCurated "SWEET doesn't have this level of granularity" |
There was a problem hiding this comment.
I don't understand the comment on granularity
There was a problem hiding this comment.
I think it just refers to the precision of the match where ENVO has the more specific term marine iceberg and sweet only iceberg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1396
The SSSOM needs review and a header for provenance.
Some format cleanup also needed.