Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Krishna to issue 430 #1364

Merged
merged 8 commits into from
Aug 18, 2022
Merged

Krishna to issue 430 #1364

merged 8 commits into from
Aug 18, 2022

Conversation

pbuttigieg
Copy link
Member

Closes #1280

@pbuttigieg pbuttigieg self-assigned this Aug 17, 2022
@pbuttigieg
Copy link
Member Author

The content review for this term is done, moving it under energy as this is not - in fact - shortwave radiation despite its label.

The energy hierarchy needs review - e.g. EM waves are not mechanical, some definitions have strange form / lack of grammar, etc

@pbuttigieg
Copy link
Member Author

pbuttigieg commented Aug 17, 2022 •
edited
Loading

Somehow, the OWL got mangled and class content mixed.

TODO:

  • Save change worth keeping
    Restore commit pre-mangle or create a fresh PR from @KrishnaTO's fork and current state of master
  • Unmangle OWL
  • Check IDs are intact and as expected vs master
  • Recreate new content / re-review

@pbuttigieg pbuttigieg merged commit 959c22f into master Aug 18, 2022
@pbuttigieg pbuttigieg deleted the KrishnaTO-issue-430 branch August 18, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pbuttigieg pbuttigieg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbuttigieg @KrishnaTO @marieALaporte