Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krishna to issue 365 #1346

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Krishna to issue 365 #1346

merged 5 commits into from
Aug 16, 2022

Conversation

pbuttigieg
Copy link
Member

Closes #1262

@pbuttigieg
Copy link
Member Author

Content review:

  • Removing precipitation as broad synonym of water-based rainfall (2abf529) - we have a superclass for that which is more accurate and has "precipitation" as a broad synonym
  • ⚠️ The count is misplaced - PATO:amount's definition only works for organisms, as its definition states. This is a legacy issue in PATO: it started as something of interest only to biology, but now that other fields want to use it, it can't take it. ENVO is already using this more broadly, which is not correct, but we will see broaden "amount" pato-ontology/pato#518. For now we leave as is, but hopefully this is fixed in PATO xref Fix use of PATO:amount in modules and design patterns #1347
  • ('characteristic of' some 'water-based rainfall') is not correct. It's characteristic of the day, not the process. Changing this to 'characteristic of' some 'one-dimensional temporal region')
  • Added rainy day and day under 1D TR - moved season there too - likely to be useful.

@pbuttigieg pbuttigieg merged commit 4310daf into master Aug 16, 2022
@pbuttigieg pbuttigieg deleted the KrishnaTO-issue-365 branch August 16, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants