Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concentration of water in soil and sublcasses #1336

Merged
merged 8 commits into from
Aug 12, 2022
Merged

concentration of water in soil and sublcasses #1336

merged 8 commits into from
Aug 12, 2022

Conversation

marieALaporte
Copy link
Contributor

@marieALaporte marieALaporte commented Aug 11, 2022

fixes #390

In this PR we created the terms:

  • concentration of water in soil
  • field capacity
  • permanent wilting point
  • water-holding capacity

@pbuttigieg
Copy link
Member

pbuttigieg commented Aug 12, 2022

Content curation report:

  • concentration of water in soil - autogenerated. In pattern.
  • field capacity - A complex concept. Adding qualifying comments. Added drained upper limit as exact synonym.
  • permanent wilting point - Definition seems incomplete and grammatically iffy. Fixed and elaborated upon. as above.
  • water-holding capacity - this is a disposition, rather than a concentration. Moved and redefined as such. The label was also made more specific (other things have water holding capacity). Created a more generic superclass.

@marieALaporte ready for your review.

@pbuttigieg pbuttigieg self-assigned this Aug 12, 2022
@pbuttigieg
Copy link
Member

@marieALaporte To clean up some other PRs, I'm merging this in.

If you need revision of any of the content, please open another PR. It should actually be easier when the others from your project are merged in too.

@pbuttigieg pbuttigieg merged commit d977cb2 into master Aug 12, 2022
@pbuttigieg pbuttigieg deleted the issue-390 branch August 12, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New classes: soil water content, soil field capacity, soil permanent wilting point
2 participants