Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many vulnerabilities with dependent gems #26

Closed
womblep opened this issue Jun 21, 2023 · 7 comments
Closed

Many vulnerabilities with dependent gems #26

womblep opened this issue Jun 21, 2023 · 7 comments

Comments

@womblep
Copy link

womblep commented Jun 21, 2023

Several of the dependent gems have open CVE records suggesting to upgrade. For example:
CVE-2023-22799 - globalid
CVE-2022-23516 - loofah

Could a new gem version be pushed with the latest working versions?

It is triggering lots of false positives in security scanning of a docker image we use this gem in.

Thanks

@skolsuper
Copy link

+1, although possibly you can just remove & .gitignore Gemfile.lock here? I see a lot of other gems' repos don't have this file.

@Envek
Copy link
Owner

Envek commented Jun 21, 2023

@womblep In general (and for this gem in particular) Ruby gem repositories’ Gemfile.lock files contains development dependencies which are used only during gem development and aren't used during runtime. So you shouldn't look at it at all.

You need to scan only your project’s Gemfile.lock which contains versions of your dependencies actually used in your app.

Please adjust your security scan to ignore Gemfile.lock files for Ruby gems.

@Envek
Copy link
Owner

Envek commented Jun 21, 2023

@skolsuper Historically, many Ruby gems didn't have lockfiles committed into version control, but it was frequently leading to cases when new contributors couldn't set up development environment due to unexpected dependencies updates. Now it is considered a best practice to keep Gemfile.lock in version control for gems.

See following resources for more context:

@Envek Envek closed this as completed in 6647ec9 Jun 21, 2023
@Envek
Copy link
Owner

Envek commented Jun 21, 2023

Released version 1.3.1 with Gemfile.lock excluded from packaging among with other development-specific files.

Please upgrade and enjoy!

@womblep
Copy link
Author

womblep commented Jun 21, 2023

@Envek I would love to stop scanning the Gemfile but unfortunately AWS Inspector does it automatically and you cant stop it :-(
AWS Inspector is also annoying in that it looks at the Gemfile.lock but not if the actual gems are installed. So it was warning about issues that were not actual issues.

I really appreciate the new gem. I will have a play and see if AWS Inspector calms down.

@Envek
Copy link
Owner

Envek commented Jun 26, 2023

@womblep, was you able to check a new gem version? Just curious whether it helped.

@womblep
Copy link
Author

womblep commented Jun 27, 2023

@Envek yes it fixed the issue completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants