-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to find PR on push event #437
Comments
Yes, when there is no pull request given in the event (given for |
BTW looking at the source code I found the option |
This fix has been released, please try without |
I can confirm it to work properly now also without |
Awesome, thanks for testing! |
It seems that the action is not able to find the PR to add the comment to if it's executed in a script that runs on a
push
event and not on apull_request event
:I had similar problems with https://github.com/platisd/clang-tidy-pr-comments but that action has an additional parameter to specify the PR is running on, and, from a commit, it's possible to get the PR using for instance:
https://github.com/jwalton/gh-find-current-pr
I suggest, if possible to add a
pull_request_id
option to be used as target PR when the action silently fail withThere is no pull request for commit XYZ
like in the provided screenshot.The text was updated successfully, but these errors were encountered: