-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendoring and glide #286
Comments
At the moment I think we can consider most of our dependencies "stable" as they are maintained by the Go team and therefore (I believe) follow backwards compatibility standards. I don't think we need to vendor until we have packages which are outside of our control (and have a risk of being non-backwards compatible). I'm also hesitant to use any vendoring system which will break cc: @otraore |
Some dependencies, such as the But it might hold some value for |
For reference, we tried something similar in Azul3D using versioned imports and after a long evaluation period decided to ditch versioning in favour of vendoring controlled by the user (not the engine). From azul3d/engine#1 by @slimsag
|
@mewmew With this model the user would also be responsible for choosing which versions of our dependencies to use too? |
@paked I would believe so. |
Indeed. The idea is to promote development and facilitate the design of a clean API. Rather than having a lot of "// Depricated" comments scattered throughout the source code, parts which are no longer supported will be removed in favour of cleaner API. Once such API-breaking changes are introduced, the change will be documented to state which versions (e.g. Git tag |
OK. I'm happy with this. |
Closing in favour of #334 |
Now that vendoring is default in golang 1.6.x and one of recommended tools these days to manage vendor dependencies is glide I would recomment to move to glide and vendoring for external dependencies.
Thoughts? @paked @EtienneBruines
The text was updated successfully, but these errors were encountered: