Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Angular): add standalone components to the @beeq/angular output target #870

Merged
merged 8 commits into from
Feb 24, 2024

Conversation

dgonzalezr
Copy link
Collaborator

We have added more flexibility over the dist-custom-elements target, allowing use on each framework-specific configuration target. The Angular output target has been improved, the value accessors are now part of the BEEQ Angular module, and no need to import them on the Angular project side.
Instead of this:

import {
  BeeQModule,
  BooleanValueAccessor,
  TextValueAccessor,
} from '@beeq/angular';

/** 💡 More Value Accessors will be exported later and should be included as well */
const VALUE_ACCESSORS = [BooleanValueAccessor, TextValueAccessor];

@NgModule({
  declarations: [AppComponent, ...VALUE_ACCESSORS],
  imports: [BeeQModule.forRoot(), BrowserModule, FormsModule, ReactiveFormsModule],
  ....
})

we will have only to do this:

@NgModule({
  declarations: [AppComponent],
  imports: [BeeQModule.forRoot(), BrowserModule, FormsModule, ReactiveFormsModule],
  ....
})

Also, we have added new value accessors: number, radio, and select, for components like bq-input[type="number"], bq-radio-group, and bq-select.

@dgonzalezr dgonzalezr requested a review from Cata1989 February 23, 2024 17:08
@dgonzalezr dgonzalezr changed the title feat(Angular standalone): add standalone components to the Angular output target feat(Angular): add standalone components to the @beeq/angular output target Feb 23, 2024
@dgonzalezr dgonzalezr force-pushed the chore/improve-output-targets branch from e8a8c26 to cfc2c48 Compare February 23, 2024 17:49
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr merged commit 055209f into main Feb 24, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the chore/improve-output-targets branch February 24, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants