Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tag): add new bq-tag component #695

Merged
merged 51 commits into from
Dec 21, 2023
Merged

feat(Tag): add new bq-tag component #695

merged 51 commits into from
Dec 21, 2023

Conversation

Cata1989
Copy link
Collaborator

@Cata1989 Cata1989 commented Dec 7, 2023 •
edited
Loading

The Tag Component is a UI element used to label and categorize content within an application. Tags are commonly used to label items with keywords or categories, making it easier to find and organize content.

Screenshot 2023-12-07 at 12 33 08

Screenshot 2023-12-13 at 14 49 34

@Cata1989 Cata1989 force-pushed the bq-tag branch 4 times, most recently from 6315c1c to 761161e Compare December 12, 2023 10:44
@Cata1989 Cata1989 added the feature 🛠 New feature or request label Dec 13, 2023
@Cata1989 Cata1989 marked this pull request as ready for review December 13, 2023 13:01
@Cata1989 Cata1989 changed the title feat(Tag): add basic bq-tag component structure WIP feat(Tag): add basic bq-tag component structure Dec 13, 2023
@dgonzalezr dgonzalezr self-assigned this Dec 14, 2023
@Cata1989 Cata1989 requested a review from dgonzalezr December 14, 2023 14:40
@dgonzalezr dgonzalezr changed the title feat(Tag): add basic bq-tag component structure feat(Tag): add new bq-tag component Dec 14, 2023
@Cata1989 Cata1989 requested a review from dgonzalezr December 15, 2023 12:42
@dgonzalezr
refactor: change component props
9d916d9 
- Use `hidden` instead of `open`
- Added `color` and `selected`
- Removed `hasColor` and `type`
 - Handle icon size and text with the new helper methods
@dgonzalezr
fix: improve hide/show handlers
eabb46c 
- Skip hidden and show handlers if tag is not removable
- Skip click and focus handlers if tag is not clickable
@dgonzalezr
fix: delegate focus and remove leftover
ebed086
@dgonzalezr
refactor: improve style to match the new changes
c8eac77
@dgonzalezr
docs: autogenerated doc
f2a41bb
@dgonzalezr
refactor(size): use xsmall instead of extra_small
ff979d6
@dgonzalezr
docs: update storybook
7ef1114
@dgonzalezr
test: update e2e tests
0634240
@Cata1989 Cata1989 requested a review from dgonzalezr December 21, 2023 10:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

dgonzalezr
dgonzalezr approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@dgonzalezr dgonzalezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉

@Cata1989 Cata1989 merged commit bc67079 into main Dec 21, 2023
5 checks passed
@Cata1989 Cata1989 deleted the bq-tag branch December 21, 2023 13:43
dgonzalezr added a commit that referenced this pull request Dec 21, 2023
@Cata1989 @dgonzalezr
feat(Tag): add new bq-tag component (#695)
a0a9548 
Co-authored-by: Dabiel González Ramos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgonzalezr dgonzalezr dgonzalezr approved these changes

@endv-bogdanb endv-bogdanb Awaiting requested review from endv-bogdanb endv-bogdanb is a code owner

Assignees

@dgonzalezr dgonzalezr

Labels
feature 🛠 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cata1989 @dgonzalezr