Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Date Picker): clear incomplete range selection #1074

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

Cata1989
Copy link
Collaborator

@Cata1989 Cata1989 commented May 29, 2024

Description

The purpose of this PR is to update the Cally library and fix some bugs. - (reset user's start date selection on calendar-range and ability to page by one month at a time or by months - pagination)

Related Issue

WickyNilliams/cally#48
WickyNilliams/cally#46

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

range_selection-ezgif.com-mute-video.mov
months-per-view-ezgif.com-mute-video.mov

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@Cata1989 Cata1989 force-pushed the fix/range-selection branch 2 times, most recently from a43474c to f38cbec Compare June 4, 2024 14:41
@Cata1989 Cata1989 self-assigned this Jun 5, 2024
@Cata1989 Cata1989 added the bug 🐛 Something isn't working label Jun 5, 2024
@Cata1989 Cata1989 marked this pull request as ready for review June 5, 2024 07:31
@Cata1989 Cata1989 requested a review from dgonzalezr June 6, 2024 06:30
@Cata1989 Cata1989 force-pushed the fix/range-selection branch from d89f736 to 6ccae77 Compare June 6, 2024 11:54
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr merged commit 2b2b329 into main Jun 7, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/range-selection branch June 7, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
Status: Released 🚀
Development

Successfully merging this pull request may close these issues.

2 participants