Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Select): remove useless CSS rules #1057

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

dgonzalezr
Copy link
Collaborator

Description

This PR removes some useless CSS rules from the Select component label.

Related Issue

Fixes #1056

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains label May 16, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr merged commit 4c4f9ff into main May 16, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/select-wrong-css-var branch May 16, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: bq-select scss variable missing declaration
3 participants