Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): prevent bqClose to propagate further #1034

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

endv-bogdanb
Copy link
Collaborator

@endv-bogdanb endv-bogdanb commented Apr 25, 2024

Description

Stop bqClose event from bq-select to propagate to parent. This prevents issues when the parent is emitting same event eg Drawer.

Related Issue

Fixes #1032

Documentation

Screenshots (if applicable)

Screen.Recording.2024-04-25.at.09.47.02.mov

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@Cata1989 Cata1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgonzalezr dgonzalezr changed the title fix(select): prevent bqClose to propagate further fix(Select): prevent bqClose to propagate further Apr 25, 2024
Copy link
Collaborator

@dgonzalezr dgonzalezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you! 👍🏻

@endv-bogdanb endv-bogdanb added the bug 🐛 Something isn't working label Apr 25, 2024
@endv-bogdanb endv-bogdanb merged commit 829ef01 into main Apr 25, 2024
6 checks passed
@endv-bogdanb endv-bogdanb deleted the fix/select branch April 25, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: bq-select leaks bqClose event from bq-tag
3 participants