Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little issue with sintax color #26

Closed
juancarlosso opened this issue Aug 18, 2023 · 3 comments
Closed

little issue with sintax color #26

juancarlosso opened this issue Aug 18, 2023 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@juancarlosso
Copy link

Works fine, but i am having this issue
Screenshot
The color sintax looks all white, i am using the "Dark theme" (originally nova)
Is this normal or something i am not doing well ?

Thanks and keep the good work! 👍

@EmranMR
Copy link
Owner

EmranMR commented Aug 19, 2023

Hi @juancarlosso, This is an issue with the tree-sitter-php

Thankfully @calebdw has already done the work and we are all patiently awaiting for his pull request to be merged by the tree-sitter-php core team 😬. Once they merge, we should be good to go.

There is only one problem for us, and that is the fact Nova provides the php syntax support as a first party, and then we have to wait for them to update their tree-sitter-php parser... As a result I am going to see if I can clone the adjusted tree-sitter-php and override the ones provided by the Nova itself this weekend or so. Will be fun to see Nova blowing up 💥 because of conflicts and etc, considering there is no way for us to disable the built-in extensions... 😂

@EmranMR EmranMR added the duplicate This issue or pull request already exists label Aug 19, 2023
@EmranMR EmranMR closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2023
@EmranMR
Copy link
Owner

EmranMR commented Aug 22, 2023

Hi @juancarlosso I would suggest upgrading your Nova extension to V1.0.0 which was released today 👀

@juancarlosso
Copy link
Author

Excellent !
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants