Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http dependency to v1 #26

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Update http dependency to v1 #26

merged 1 commit into from
Apr 2, 2024

Conversation

max-te
Copy link
Contributor

@max-te max-te commented Apr 1, 2024

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Updates to the stabilized version 1 of http crate. Also updates reqwest dev-dependency to 0.12, which is compatible with http 1.x.
This makes tame-oidc compatible with reqwest 0.12+.

@max-te
Update http dep to v1
88f529a 
Also update reqwest dev-dependency to 0.12,
which is compatible with http 1.x.
@max-te max-te requested a review from vojd as a code owner April 1, 2024 08:02
vojd
vojd approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@vojd vojd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! We will wait a little bit with bumping the crate version but really good to get this into main.

@vojd vojd merged commit 01c4fb5 into EmbarkStudios:main Apr 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojd vojd vojd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-te @vojd