Replace base64 with data-encoding #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
has was thinking the same, though we do have tons of usages of it but gradually switching away sounds prudent. |
|
Yah, this first pass is just to remove it from the crates we maintain, we've been dealing with multiple versions of base64 as it is so it's not a huge difference in the short term, but hopefully recent discussion about it will make PRs to replace it in project's we don't maintain easier. https://twitter.com/mycoliza/status/1708933310548935148 was what reminded me how bad the API is, and then I read the maintainer's posts on various issues and was like...yah nope. |
|
heh yeah read the same and thought the same also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base64 API has gotten significantly worse so we are moving away from it in favor of data-encoding.