Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Rust version changed in patch release #21

Closed
wezm opened this issue Jan 29, 2020 · 2 comments · Fixed by #22
Closed

Minimum Rust version changed in patch release #21

wezm opened this issue Jan 29, 2020 · 2 comments · Fixed by #22
Labels
bug Something isn't working

Comments

@wezm
Copy link

wezm commented Jan 29, 2020

I'm not sure if you consider this a bug or not (people seem to have differing opinions on the interaction between changing minimum supported Rust version and semver) but I thought I'd point it out.

The 0.3.1 patch release introduced the use of #[non_exhaustive], which means it will now only compile on stable Rust 1.40.0.

@wezm wezm added the bug Something isn't working label Jan 29, 2020
@Jake-Shadle
Copy link
Member

Ahh, thanks for pointing this out, I remember noticing that addition but didn't reflect that it would change the minimum Rust version. I think in this case I'm going to publish a new patch without #[non_exhaustive] and yank the previous version, as that enum is only an input to this lib, and I would actually prefer people to get compile errors if they are for some reason matching on it in their own crates and it changes in the future.

@wezm
Copy link
Author

wezm commented Jan 29, 2020

Awesome, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants