Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future cleanup: remove allow(clippy::use_self) once we rustup past 2021-02-26. #459

Closed
eddyb opened this issue Mar 1, 2021 · 0 comments · Fixed by #470
Closed

future cleanup: remove allow(clippy::use_self) once we rustup past 2021-02-26. #459

eddyb opened this issue Mar 1, 2021 · 0 comments · Fixed by #470
Labels
a: rust-lang Issues specific to rust-lang/rust. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: enhancement A new feature or improvement to an existing one.

Comments

@eddyb
Copy link
Contributor

eddyb commented Mar 1, 2021

I've been leaving #[allow(clippy::use_self)] across the codebase in places where the lint is wrong and Self can't be written (either type parameter mismatch like Foo<T> vs Foo<U>, or nested items that couldn't possibly name Self, etc.).

I suspect rust-lang/rust-clippy#6179 fixed most (if not all) of the use_self bugs, and that seems to be part of rust-lang/rust#82514, and so was likely included in the 2021-02-26 nightly.

I can't reproduce the bugs on the Rust playground, and that seems to only provide latest nightly for tools (i.e. Stable/Beta/Nightly toggle is ignored), so that seems to agree with my expectations.

@XAMPPRocky XAMPPRocky added a: rust-lang Issues specific to rust-lang/rust. t: enhancement A new feature or improvement to an existing one. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. labels Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: rust-lang Issues specific to rust-lang/rust. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: enhancement A new feature or improvement to an existing one.
Projects
None yet
2 participants