Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings on our crates on lib.rs #43

Open
14 tasks done
repi opened this issue Feb 2, 2022 · 2 comments
Open
14 tasks done

Fix warnings on our crates on lib.rs #43

repi opened this issue Feb 2, 2022 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@repi
Copy link
Contributor

repi commented Feb 2, 2022

lib.rs has new support that runs some custom lints to validate crate definitions and metadata, we should go through all of the warnings on our Embark crates and try and fix the warnings and recommendations for our crates, full list here:

https://lib.rs/~embark-studios/dash

@repi repi changed the title Fix warnings on our crates on lib.rs (https://lib.rs/~embark-studios/dash) Fix warnings on our crates on lib.rs Feb 2, 2022
@repi repi added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 2, 2022
@repi repi changed the title Fix warnings on our crates on lib.rs Fix warnings on our crates on lib.rs (https://lib.rs/~embark-studios/dash) Feb 2, 2022
@repi repi changed the title Fix warnings on our crates on lib.rs (https://lib.rs/~embark-studios/dash) Fix warnings on our crates on lib.rs Feb 2, 2022
@celialewis3
Copy link
Member

Looks like we can close this one, since all tasks are complete?

@repi
Copy link
Contributor Author

repi commented Feb 23, 2022

oh awesome that @Jake-Shadle fixed so many already!

the listed tasks are complete but there are a bunch more on the page that should be fixed up: https://lib.rs/~embark-studios/dash

though not all of them are fixable, for example have private repos for some crates (so they are not technically open source, just published on crates.io). but many of the listings in there still think need to be followed up on to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants