Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make on_crash callback FnOnce #79

Closed
CrabNejonas opened this issue Jun 29, 2023 · 1 comment · Fixed by #81
Closed

Make on_crash callback FnOnce #79

CrabNejonas opened this issue Jun 29, 2023 · 1 comment · Fixed by #81
Labels
enhancement New feature or request

Comments

@CrabNejonas
Copy link

Is your feature request related to a problem? Please describe.
Currently the on_crash callback has to be Fn, which imposes quite heavy restrictions on the closures user are able to pass.

Describe the solution you'd like
If I'm not mistaken the callback will only ever be called once during the lifetime of the instumented app (bc it's gonna crash afterwards) so it should be possible to change the signature to FnOnce to allow consumers maximum flexibility (especially use move closures)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@CrabNejonas CrabNejonas added the enhancement New feature or request label Jun 29, 2023
@Jake-Shadle
Copy link
Member

Seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants