Fix pr 14: fixes to swagger parser #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute keys I did not author this code, I just fixed it. Maybe best to adapt the original PR’s.
I add some example methods I missed, and made sure that future missing example methods do not crash the normal operation, but instead show some kind of warning so it could (hopefully) be fixed. I am aware that `puts` is probably not the best way, but not sure what to use instead? `warn` ? Something silenceable?
|
Thank you @nathanvda, I merged #14 then fixed the conflicts then merged #21. That did the trick 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new branch containing all the work in PR #14 and added a small fix to make sure the tests work.
I am not sure if this the correct way to go about it. I had to locally get the
masterbranch from bothvincentvanbush and prograils to be able to 1) reproduce the error and 2) be able to fix it. My fix is very small, it is just this line:
inside the
db_record.rbfile. Unfortunately due to my git inability (I am fine using git on a day to day basis, but still when actually git-fu is needed I am still lacking skillz) I inadvertently overwrote the author-name on the last commit.So probably best is just apply the fix on top of PR 14? Proceed as you see fit.
When testing locally I also encountered some missing
*_examplemethods so IIf you fix PR14 instead (which is more honour to the original authors) I will open a new PR with my fixes applied (if that is ok).