Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using of the term entropy is unconsistent and misleading #253

Open
Sosthene00 opened this issue Dec 3, 2020 · 1 comment
Open

Using of the term entropy is unconsistent and misleading #253

Sosthene00 opened this issue Dec 3, 2020 · 1 comment

Comments

@Sosthene00
Copy link

Functions like wally_tx_add_elements_raw_input are expecting entropy as an argument. The doc says that this is "Entropy for the asset tag calculation."

The man for wally_tx_elements_issuance_generate_entropy says "Calculate the asset entropy from a prevout and the Ricardian contract hash."

Actually entropy in wally_tx_add_elements_raw_input is contract_hash argument to wally_tx_elements_issuance_generate_entropy.

I think this is all very confusing, and I suggest at least to mention explicitly what is expected as entropy here.

Or maybe clarify variable names.

@jgriffiths
Copy link
Contributor

@Sosthene00 I agree this is confusing. Once the elements PSBT support is finalised in the elements codebase, and #218 updated to reflect it, I hope to standardise the naming between elements txs and the PSBT code since this will be an API change anyway.

If you encounter any other specific examples that caused you confusion please feel free to document them here and I'll try to make sure they are covered under that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants