Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker containers #1104

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

AaronDewes
Copy link

This adds an automatically build Docker container using GitHub actions and the GitHub container registry.

This will make it easier to use elements in node packages like Citadel or Umbrel.

Inspired by the lncm docker bitcoin container: https://github.com/lncm/docker-bitcoind

@AaronDewes AaronDewes marked this pull request as ready for review March 27, 2022 16:37
@AaronDewes AaronDewes changed the title WIP: Docker containers Docker containers Mar 27, 2022
@AaronDewes
Copy link
Author

The docker container now has been tested on Citadel and seems to work successfully, I am syncing the chain with it currently.

I'll now also add a workflow to make sure the container is also built when a new tag is created.

@wtogami
Copy link
Contributor

wtogami commented Jul 19, 2022

Hi Aaron,
I appreciate you put effort into this. Similarly to Bitcoin Core, Elements is very cautious when it comes to official distributed binaries. Both projects distribute only reproducible binaries to reduce the risk of supply chain attack. Both projects would not distribute official docker containers that increase the attack surface.

For these reasons I don't expect this PR to ever be accepted into this repo. Instead we strongly recommend that distributors be responsible for their own builds. It would be best to maintain your docker build definitions elsewhere.

@wtogami
Copy link
Contributor

wtogami commented Jul 20, 2022

Aaron informed me that he has reproducible docker containers working for other components. That would be interesting to consider here.

Not necessarily as the "supported" distribution but it's at least less dangerous than how other people distribute binary docker containers without any verifiability.

@wtogami
Copy link
Contributor

wtogami commented Jul 20, 2022

If I understand it correctly, Debian these days is reproducible but not clean bootstrap verified?

@philippem
Copy link
Contributor

philippem commented Sep 13, 2022

Hello @AaronDewes
Blockstream publishes docker images that package the official gitian-built Elements binaries.
https://hub.docker.com/r/blockstream/elementsd

The image is very simple, you will need to specify an entrypoint and volumes for conf and data.

For example, running the elementsd in regtest mode in a terminal:

docker run -it --entrypoint /usr/local/bin/elementsd  blockstream/elementsd:0.21.0.2 -regtest -daemon=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants