-
Notifications
You must be signed in to change notification settings - Fork 123
COW metadata / no metadata on metakeys #3610
Comments
Thank you for reporting the problem! Actually the metakeys should be completely read-only, see #3609 |
I updated the issue |
I mark this issue stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping the issue by writing a message here or create a new issue with the remainder of this issue. |
@markus2330 This should probably be implemented together with the removal of |
I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue. |
I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue. |
See #4744 |
I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue. |
I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue. |
Because metadata on meta keys is not allowed we can use Copy-On-Write semantics for metadata. Therefore all keys of the namespace
KEY_NS_META
should automatically have the flagsKEY_FLAG_RO_NAME
,KEY_FLAG_RO_VALUE
andKEY_FLAG_RO_META
set duringkeyVNew
.This ensures that
keySetMeta
will fail. It also avoids any problems withksDeepDup
(#3609), since the need for deep-copies of metadata is removed. ThereforekeyDup
(#3606) can just create a shallow-copy of the metadata without any further implications.Additionally,
KEY_NS_META
keys should at all times fulfillkey->meta == NULL
andkeyMeta()
should returnNULL
instead of allocating a newKeySet
.The text was updated successfully, but these errors were encountered: