Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

kdb run_all does not execute external tests #2372

Closed
2 tasks
markus2330 opened this issue Feb 6, 2019 · 3 comments · Fixed by #2375
Closed
2 tasks

kdb run_all does not execute external tests #2372

markus2330 opened this issue Feb 6, 2019 · 3 comments · Fixed by #2375
Assignees
Labels
Milestone

Comments

@markus2330
Copy link
Contributor

Steps to Reproduce the Problem

Install Elektra and run:

kdb stash
kdb run_all

Expected Result

It runs all test cases.

Actual Result

Running check_spec
Running external_check*

The command kdb-full external_check* is not known
[...]
error: external_check*


Following test cases failed: 
testmod_lua
testmod_network
testmod_yaypeg
external_check*

run_all RESULTS: 146 test(s) done 4 error(s).

System Information

  • Elektra Version: master
  • Debian Stretch

Further Log Files and Output

kdb list-tools | grep external

has no output, so it seems like the external_check is not installed (is not part of the Debian package).

So there are actually two problems:

  • that the external test case is not installed
  • the failures in the case if external test cases are not installed

Why not simply naming it also check_external_... Then e63db7d would not have been necessary, which would avoid the second problem.

@markus2330 markus2330 added the bug label Feb 6, 2019
@markus2330 markus2330 added this to the 0.8.26 milestone Feb 6, 2019
@kodebach
Copy link
Member

kodebach commented Feb 6, 2019

Is there any reason we aren't using CPack for building the debian package? That way make install would always use the same files as the debian package.

@markus2330
Copy link
Contributor Author

We used CPack a long time ago. It might still work, the code is still there: cmake/ElektraPackaging.cmake

Afaik CPack cannot produce modular packages (everything is put into one package) and this package would be huge with a ridiculous amount of dependencies. E.g. elektra-dbg alone is > 70 MB, which is enormous compared to the ~100k base libraries.

I already have many installations where only parts of Elektra is installed. Actually, I only have few places where everything is installed.

@kodebach
Copy link
Member

kodebach commented Feb 6, 2019

It should be possible to use CPack components to produce multiple packages. Might be worth investigating for #2353.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants