Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fuel Generator fuel input configurable. #778

Open
DonBruce64 opened this issue Oct 1, 2017 · 5 comments
Open

Make Fuel Generator fuel input configurable. #778

DonBruce64 opened this issue Oct 1, 2017 · 5 comments

Comments

@DonBruce64
Copy link

Current fuel generator setup has static fuel values for fuel generator and turbine. This does not yield itself well to modpacks as it can result in the fuel values being over-powered should fuel be plentiful. I understand generators are supposed to be a 'bad' power option, but if you have tanks full of IE biodiesel or GC fuel then what does it matter? Especially when the 200V unit can make as much power as two 200V heat turbines with far less explodey-ness.

@Baughn
Copy link
Contributor

Baughn commented Oct 11, 2017

The fuel list should be moved to the config file, I think.

@DonBruce64
Copy link
Author

Might a way to do it be a list with String keys tied to values? Have EA iterate through the liquid list and if it finds a liquid with a name that exists in the list take the number value as the fuel value? I do something similar with MFS for fuel compatibility, however I have it auto-populate the config with all liquid values, which may not be what you want. You could always statically put the liquids in, however that might result in some uncommon mods with oddball liquids not being compatible without a PR.

@bloxgate
Copy link
Member

The API in #652 does support changing fuels as well, although it doesn't provide any minetweaker support for such actions.

@DonBruce64
Copy link
Author

That API would require other modders to include it in their builds to function with EA, yes? Does that mean that it wouldn't be configurable for modpacks/servers should modders decide not to bother with inclusion? Or are we going to see and ELNTweaker offshoot? Trying to see how the API would factor in with the 99% of players who want to configure things and don't know how to code. Not saying it's wrong to use that rather than a config, however I worry about the limitations of such a method.

@bloxgate
Copy link
Member

In theory you should be able to just drop the API into your mods src or use the API module in gradle since I've setup the @API annotation. Actually a good chunk of it also doesn't rely on ELN being present.

I know of at least one modpack that had a mod they made specificly for tweaks, though that probably is a bit more effort than normal for most modpack creators.

I suppose it would be possible to add minetweaker support for the fuel lists too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants