Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup crash with AOBD #693

Open
mpevner opened this issue Mar 8, 2017 · 10 comments
Open

Startup crash with AOBD #693

mpevner opened this issue Mar 8, 2017 · 10 comments
Labels
Milestone

Comments

@mpevner
Copy link

mpevner commented Mar 8, 2017

Using the builds from Safranil, 453 [0] and higher crash on startup with AOBD present.
The pertinent line appears as follows:

cpw.mods.fml.common.LoaderException: java.lang.IllegalAccessError: tried to access field mods.eln.Eln.maceratorRecipes from class ganymedes01.aobd.recipes.modules.ElectricalAge

And the full log is here: https://paste.ee/p/UN7FZ

I've tossed this as an issue on the AOBD repo [1], but thought to also bring it to your attention, as AOBD has not been worked on in some time.

[0] http://ci.safranil.fr/job/ElectricalAge/453/
[1] buttilda/Another-One-Bites-the-Dust#129

@Baughn
Copy link
Contributor

Baughn commented Mar 8, 2017

Can you try removing 'private' from maceratorRecipes?

@mpevner
Copy link
Author

mpevner commented Mar 8, 2017

I adjusted as follows in Eln.java and compiled:

RecipesList maceratorRecipes = new RecipesList();
void registerMacerator(int id) {

It did not work however.

@Baughn Baughn added this to the 1.15 milestone Mar 8, 2017
@Baughn
Copy link
Contributor

Baughn commented Mar 8, 2017

Ok. I'll make sure it gets fixed before the next release; thanks for telling us.

@cm0x4D cm0x4D added the bug label Mar 10, 2017
@mpevner
Copy link
Author

mpevner commented Mar 17, 2017

I gave this another go, explicitly changing every Private RecipesList to Public RecipesList in Eln.java. This seems to work so far, but I can see this as being a rather hacky fix. On a probably related note, I think this breaks NEI. I am investigating further in that regard.

@mpevner
Copy link
Author

mpevner commented Mar 17, 2017

Amendment: This was an issue with the mod NEI Integration, which was using an S instead of a Z. I presume at some point the spelling in this mod changed. A custom compile of NEI Integration later and it is resolved.
...I'm not entirely sure of my reading this, but the issue for NEI appears to be magnetiser/magnetizer. In this matter NEI crashes on attempt to view any recipe.
Error excerpt as follows:

java.lang.NoSuchFieldError: magnetiserRecipes
	at tonius.neiintegration.mods.electricalage.RecipeHandlerMagnetizer.getRecipes(RecipeHandlerMagnetizer.java:21)
	at tonius.neiintegration.mods.electricalage.RecipeHandlerElnBase.loadCraftingRecipes(RecipeHandlerElnBase.java:71)
	at codechicken.nei.recipe.TemplateRecipeHandler.loadCraftingRecipes(TemplateRecipeHandler.java:331)
	at tonius.neiintegration.RecipeHandlerBase.loadCraftingRecipes(RecipeHandlerBase.java:100)
	at codechicken.nei.recipe.TemplateRecipeHandler.getRecipeHandler(TemplateRecipeHandler.java:466)
	at codechicken.nei.recipe.GuiCraftingRecipe.openRecipeGui(GuiCraftingRecipe.java:20)

@mpevner
Copy link
Author

mpevner commented Oct 17, 2017

I am roughly aware there are plans for a API to be implemented, but in the interim, would it be reasonable to revert the RecipesList's to public from private?

@bloxgate
Copy link
Member

The API is near finished at the moment actually. See #652

Though it'd be on AOBD to update to use it, if they're still doing 1.7.10 releases.

@mpevner
Copy link
Author

mpevner commented Oct 17, 2017

Super awesome! Even if they don't update, the source is visible at least so I can always make my own version (I can't seem to find a license regarding source for AOBD).

@bloxgate
Copy link
Member

bloxgate commented Oct 17, 2017

Curse says its All Right's Reserved. https://minecraft.curseforge.com/projects/another-one-bites-the-dust/license

@mpevner
Copy link
Author

mpevner commented Oct 17, 2017

Hopefully by default and not choice. With luck, the author can be reached and this can be worked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants