-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.0.0 (was going to be v0.2.0, but refactor got bigger) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nickreese
changed the title
DRAFT: V1.0.0
DRAFT: V1.0.0 (was going to be v0.2.0, but refactor got bigger)
Sep 16, 2020
@halafi Moved the majority of the server implementation to a hook so it can easily be overwritten, customized, or whatever users want to do. Tests there are failing :/ |
halafi
reviewed
Sep 22, 2020
nickreese
changed the title
DRAFT: V1.0.0 (was going to be v0.2.0, but refactor got bigger)
V1.0.0 (was going to be v0.2.0, but refactor got bigger)
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V1 Roadmap:
elder.config.js
locations
key in favor ofsrcDir
,distDir
, androotDir
process.cwd()
removed unlessrootDir
is not set, then it is called once to set it.origin
is not set.Shortcodes:
shortcodes.js
helpers.shortcode
added for easy inlining of shortcodes within svelte templates@html helpers.shortcode({name:'foo' props: {key: 'val'}, content: 'string'});
Rollup Config:
process.cwd()
in favor of theelder.config.js
refactor../src/components/[name]/[Name].svelte
or./src/compontents/[Name].svelte
data
function manipulation, prevent people from causing issues for themselves.Server:
Build:
Other:
useful errors when there are no permalinks due to not adding a
request.route
property when manipulatingallRequests
.validation for the
data
key when validating routes.route
data
functions have read only props. This keeps from things being broken unexpectedly.forked, meta-shortcodes to add async support, updated the test.
show useful error on non-self closing tags in partialHydration.
add
allRequests
tobuildComplete
hookmoved Elder.js' express server into a function on the
middleware
hook.depreciating 'routeHTML' which is passed into 'Layout' svelte templates to be 'routeHtml'.
TODO Post Release:
link
from the template.elder.config.js
and removeprocess.cwd()
To Document:
/build/
folder to match theirsrcDir
and update their svelte preprocessor.Upgrading to v1.0.0:
Below are the breaking changes between v1 and earlier versions:
link
helper is removed from templates. You can access it athelpers.permalinks
the same way as before solink.blog({slug: "foo"})
becomeshelpers.permalinks.blog({slug: "foo"})
routeHtml
orrouteHTML
in the Layout.svelte in the Elder.js template has been changed totemplateHtml
. If your getting no output from your templates this is your issue. Rename this variable and things should work again.process.browser
replacements in rollup.config are now 'process.env.componentType' which will returnbrowser
orserver
. Remember process.env variables are strings. soprocess.env.componentType === 'server'
is the correct way to check if a component is rendering on the server.elder.config.js
. If you defined anything in theelder.config.js
under thelocations
key you'll need to rework those into thedistDir
,srcDir
, androotDir
.siteUrl
in elder.config.js was changed toorigin
and you'll get an error if you don't set it.srcDir
to the build folder found in yourtsconfig
.File / Hook Changes:
./src/assets/
folder has been moved to./assets/
(project root).copyAssetsToPublic
hook as shown below.rollup.config.js
to be updated as shown below.Tests Needed
elderProcessShortcodes
Shortcodes for testing: