Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining extensions in svelte config #107

Merged

Conversation

bbuhler
Copy link
Contributor

@bbuhler bbuhler commented Dec 4, 2020

Allows overriding extensions via svelte.config.js:

module.exports = {
  extensions: ['.svelte', '.html'],
};

@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #107 (47b9f49) into master (34e54d2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files          41       41           
  Lines        1484     1484           
  Branches      340      341    +1     
=======================================
  Hits         1399     1399           
  Misses         85       85           
Impacted Files Coverage Δ
src/rollup/rollupPlugin.ts 94.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e54d2...47b9f49. Read the comment docs.

@nickreese
Copy link
Contributor

@bbuhler Thanks for this. Good implementation. Can you add it to the Docs as well? https://github.com/Elderjs/docs/blob/master/elderguide.com/elderjs.md

@nickreese nickreese merged commit e079c98 into Elderjs:master Dec 9, 2020
@bbuhler
Copy link
Contributor Author

bbuhler commented Dec 11, 2020

Hi @nickreese, thanks for merging. 🙂️

Would you mind releasing a new minor/patch version with that change?
I am using a dependency from which I import HTML files as Svelte components.

Though this implementation is enough for my use case, using HTML files for Svelte components project wide would probably require more changes in various places of the Rollup config.

After this is done, I would consider adding it to the Docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants