Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not process sub hydrate-components when rendering a component #259

Open
eight04 opened this issue Nov 9, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@eight04
Copy link
Contributor

eight04 commented Nov 9, 2022

const innerHtml = mountComponentsInHtml({

When rendering a component, sub hydrate-components are collected and added to the current page. Ideally, they should be processed after the entire HTML page is built. With the current code:

  1. The page may include a hydrated component which is actually not on the page. For example, when Layout.svelte doesn't output templateHtml.
  2. mountComponentsInHtml is applied to the same string multiple times.
@eight04 eight04 added the bug Something isn't working label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant