bug: fix blocking perf bug

Elderjs · Mar 8, 2022 · 4a77268 · 4a77268
1 parent aa922f6
commit 4a77268
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@elderjs/elderjs",
-  "version": "1.6.11",
+  "version": "1.6.12",
   "main": "./build/index.js",
   "types": "./build/index.d.ts",
   "engineStrict": true,

diff --git a/src/Elder.ts b/src/Elder.ts
@@ -349,8 +349,6 @@ class Elder {
         this.router = prepareRouter(this);
         this.perf.end(`startup.prepareRouter`);
 
-        this.markBootstrapComplete(this);
-
         this.perf.end('startup');
         this.perf.stop();
 
@@ -363,6 +361,8 @@ class Elder {
             displayPerfTimings([...this.perf.timings]);
           }
         }
+
+        this.markBootstrapComplete(this);
       });
     });
   }

diff --git a/src/utils/prepareServer.ts b/src/utils/prepareServer.ts
@@ -1,17 +1,20 @@
 function prepareServer({ bootstrapComplete }) {
   // eslint-disable-next-line consistent-return
   return async function prepServer(req, res, next) {
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    const { runHook, perf, ...bootstrap } = await bootstrapComplete;
-
-    await runHook('middleware', {
-      ...bootstrap,
-      runHook,
-      req,
-      next,
-      res,
-      request: { type: 'server' },
-    });
+    try {
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
+      const { runHook, ...bootstrap } = await bootstrapComplete;
+      await runHook('middleware', {
+        ...bootstrap,
+        runHook,
+        req,
+        next,
+        res,
+        request: { type: 'server' },
+      });
+    } catch (e) {
+      console.error(e);
+    }
   };
 }