Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the inferDimensions option #18

Merged
merged 4 commits into from
Jan 23, 2023
Merged

feat: add the inferDimensions option #18

merged 4 commits into from
Jan 23, 2023

Conversation

ouuan
Copy link
Contributor

@ouuan ouuan commented Jan 22, 2023

The dimensions option adds width and height attributes to the <img> element based on the dimensions of the last src.

This closes #10.

It seems that other APIs have no good documentation yet, so I don't know where to put the documentation.

The dimensions option adds `width` and `height` attributes to the <img>
element based on the dimensions of the original image.
@netlify
Copy link

netlify bot commented Jan 22, 2023

Deploy Preview for image-presets ready!

Name Link
🔨 Latest commit 8d533a2
🔍 Latest deploy log https://app.netlify.com/sites/image-presets/deploys/63cea9a684ebbd0008f9a187
😎 Deploy Preview https://deploy-preview-18--image-presets.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ouuan ouuan marked this pull request as draft January 22, 2023 11:22
@ouuan ouuan marked this pull request as ready for review January 22, 2023 12:00
Copy link
Owner

@ElMassimo ElMassimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

Could we rename dimensions to inferDimensions?

@ouuan ouuan changed the title feat: add the dimensions option feat: add the inferDimensions option Jan 23, 2023
@ElMassimo ElMassimo merged commit a3269f9 into ElMassimo:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Include generated image dimensions
2 participants