Jsilva/change docker files for jazzy #260

JesusSilvaUtrera · 2024-07-17T07:55:11Z

🎉 New feature

This is part of the migration to Jazzy
Related to #266

Summary

Second PR for the migration to Jazzy. This time, I have included the changes to the docker directory to make it work with the new image.

Test it

Follow the instruction of the docker/README.md file to test it completely. See if the rosdep tool installs all necessary dependencies and the workspace builds fine.

Checklist

Signed all commits for DCO
Added tests
Added example and/or tutorial
Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

* Improves andino_navigation package. (#224) Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Add basic Platform IO instructions (#229) Signed-off-by: Gary Servin <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Modify Shell class API to allow dependency injection (#221) Signed-off-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Fixed wheel diameter in URDF (#93) Signed-off-by: JesusSilvaUtrera <[email protected]> * Added YAML file for default camera intrinsics (#169) Signed-off-by: JesusSilvaUtrera <[email protected]> * Adds references to o3de and isaac_sim simulations. (#232) Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Added README for andino_bringup (#233) Signed-off-by: JesusSilvaUtrera <[email protected]> * Added binaries installation docs (#234) Signed-off-by: JesusSilvaUtrera <[email protected]> * andino_apps package created and andino_navigation package updated (#235) * andino_apps package created and andino_navigation package updated Signed-off-by: JesusSilvaUtrera <[email protected]> * Minor changes from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Update andino_navigation README with changes from PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Add andino_apps package to ci.yaml Signed-off-by: JesusSilvaUtrera <[email protected]> * Fixed minor issues from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Added 'andino_apps' to the general README Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]> * Minimal change to test launch file Signed-off-by: JesusSilvaUtrera <[email protected]> * Added webcam.yaml file and intrinsics are now publishing Signed-off-by: JesusSilvaUtrera <[email protected]> * Added raspicam.yaml with camera intrinsics and updated instructions in andino_hardware/README Signed-off-by: JesusSilvaUtrera <[email protected]> * Changed the 'camera_info_url' to be relative path Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> Signed-off-by: Gary Servin <[email protected]> Signed-off-by: Javier Balloffet <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Co-authored-by: Gary Servin <[email protected]> Co-authored-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: JesusSilvaUtrera <[email protected]>

JesusSilvaUtrera · 2024-07-17T07:58:15Z

@francocipollone to approve this, we should test it on the real robot to see if any changes are needed, I was able to test the camera node locally with my webcam but just to be sure everything is working.

Signed-off-by: Franco Cipollone <[email protected]>

francocipollone

LGTM

I'd merge it and we can continue tracking missing stuff in the issue

francocipollone · 2024-08-14T12:05:24Z

docker/run.sh

+# chown -R "$USER" ${REPOSITORY_FOLDER_PATH}/.build
+# chown -R "$USER" ${REPOSITORY_FOLDER_PATH}/.install


Is it ok to have it commented?

I will remove those lines, I left them JIC I needed to uncomment them on the future.

francocipollone · 2024-08-14T12:06:02Z

docker/run.sh

@@ -113,6 +115,7 @@ sudo docker run --privileged --net=host -it $NVIDIA_FLAGS \
       -v ${REPOSITORY_FOLDER_PATH}/.build:$WORKSPACE_ROOT_CONTAINER/build:rw \
       -v ${REPOSITORY_FOLDER_PATH}/.install:$WORKSPACE_ROOT_CONTAINER/install:rw \
       -v $SSH_PATH:$SSH_PATH \
+       -u 1000:1000 \


Is it ok to use an arbitrary uid and gid?

It's not entirely arbitrary, that's the uid and gid that was used with my user on Ubuntu22, so I tried to replicate that behavior as much as I could on Ubuntu24. I think we should be fine for now.

francocipollone · 2024-08-14T12:06:36Z

docker/run.sh

+WORKSPACE_SRC_CONTAINER=/home/ubuntu/ws/src/$REPOSITORY_FOLDER_NAME
+WORKSPACE_ROOT_CONTAINER=/home/ubuntu/ws


Is it going to find it on any computer if we use ubuntu as user?

It should because the same user would be used on any computer that runs the container, it's not as we did on Ubuntu22 where we were using the current user on the host machine.

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Added all necessary changes to the README Signed-off-by: JesusSilvaUtrera <[email protected]> * Removed a blank line Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: Franco Cipollone <[email protected]> Co-authored-by: Lola Segura <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: Sakura286 <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Minor update to andino_hardware readme. Signed-off-by: JesusSilvaUtrera <[email protected]>

* Improves andino_navigation package. (#224) Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Add basic Platform IO instructions (#229) Signed-off-by: Gary Servin <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Modify Shell class API to allow dependency injection (#221) Signed-off-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Fixed wheel diameter in URDF (#93) Signed-off-by: JesusSilvaUtrera <[email protected]> * Added YAML file for default camera intrinsics (#169) Signed-off-by: JesusSilvaUtrera <[email protected]> * Adds references to o3de and isaac_sim simulations. (#232) Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Added README for andino_bringup (#233) Signed-off-by: JesusSilvaUtrera <[email protected]> * Added binaries installation docs (#234) Signed-off-by: JesusSilvaUtrera <[email protected]> * andino_apps package created and andino_navigation package updated (#235) * andino_apps package created and andino_navigation package updated Signed-off-by: JesusSilvaUtrera <[email protected]> * Minor changes from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Update andino_navigation README with changes from PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Add andino_apps package to ci.yaml Signed-off-by: JesusSilvaUtrera <[email protected]> * Fixed minor issues from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Added 'andino_apps' to the general README Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]> * Minimal change to test launch file Signed-off-by: JesusSilvaUtrera <[email protected]> * Added webcam.yaml file and intrinsics are now publishing Signed-off-by: JesusSilvaUtrera <[email protected]> * Added raspicam.yaml with camera intrinsics and updated instructions in andino_hardware/README Signed-off-by: JesusSilvaUtrera <[email protected]> * Changed the 'camera_info_url' to be relative path Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> Signed-off-by: Gary Servin <[email protected]> Signed-off-by: Javier Balloffet <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Co-authored-by: Gary Servin <[email protected]> Co-authored-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: Franco Cipollone <[email protected]>

Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

* Added all necessary changes to the README Signed-off-by: JesusSilvaUtrera <[email protected]> * Removed a blank line Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]>

…usSilvaUtrera/andino into jsilva/change_docker_files_for_Jazzy

JesusSilvaUtrera · 2024-09-16T12:54:23Z

I will close and open a new fresh PR with the changes.

JesusSilvaUtrera requested review from francocipollone and jballoffet as code owners July 17, 2024 07:55

JesusSilvaUtrera and others added 3 commits July 17, 2024 09:55

Remove andino_gz_classic and andino_apps references (#259)

b08d940

Signed-off-by: JesusSilvaUtrera <[email protected]>

Modified docker files to build and run the new image

5a7757c

Signed-off-by: JesusSilvaUtrera <[email protected]>

JesusSilvaUtrera force-pushed the jsilva/change_docker_files_for_Jazzy branch from a9bf2e6 to 5a7757c Compare July 17, 2024 07:55

Merge branch 'jazzy' into jsilva/change_docker_files_for_Jazzy

0e51b01

francocipollone and others added 4 commits July 19, 2024 16:21

Updates CHANGELOG.

bd71b50

Signed-off-by: Franco Cipollone <[email protected]>

0.2.0

984995d

Updates README.md

0a00356

Signed-off-by: Franco Cipollone <[email protected]>

Adds reference to andino_rmf repo (#263)

8da83f5

Signed-off-by: Franco Cipollone <[email protected]>

francocipollone approved these changes Aug 14, 2024

View reviewed changes

francocipollone requested changes Aug 14, 2024

View reviewed changes

JesusSilvaUtrera and others added 16 commits September 3, 2024 12:33

Updated the CI and the run.sh

6012cc3

Signed-off-by: JesusSilvaUtrera <[email protected]>

Minor changes to clean the code a bit

3d5ef69

Signed-off-by: JesusSilvaUtrera <[email protected]>

Updated the first installation instructions

5a21f9c

Include robot assembly (#267)

9f027b8

* Added all necessary changes to the README Signed-off-by: JesusSilvaUtrera <[email protected]> * Removed a blank line Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]>

Merge remote-tracking branch 'upstream/humble' into jazzy

13acdc0

Merge branch 'jazzy' into jsilva/change_docker_files_for_Jazzy

210ac60

Allow custom configuration (#243)

7d8d9f8

Signed-off-by: JesusSilvaUtrera <[email protected]>

Add new Arduino diagram (#249)

c9c6d30

Signed-off-by: JesusSilvaUtrera <[email protected]>

Update connections diagram (#252)

f3f41ed

Signed-off-by: JesusSilvaUtrera <[email protected]>

Adds discord link (#253)

2d25d47

Signed-off-by: Franco Cipollone <[email protected]> Co-authored-by: Lola Segura <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

explicitly add <cstdint> header for fixed width integer types (#254)

1e15ad0

Signed-off-by: Sakura286 <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Update andino_hardware README.md (#256)

1ec9748

Minor update to andino_hardware readme. Signed-off-by: JesusSilvaUtrera <[email protected]>

Remove andino_gz_classic and andino_apps references (#259)

4475e51

Signed-off-by: JesusSilvaUtrera <[email protected]>

Modified docker files to build and run the new image

b649747

Signed-off-by: JesusSilvaUtrera <[email protected]>

Updated the CI and the run.sh

6140f46

Signed-off-by: JesusSilvaUtrera <[email protected]>

JesusSilvaUtrera and others added 8 commits September 16, 2024 14:51

Minor changes to clean the code a bit

a21d69c

Signed-off-by: JesusSilvaUtrera <[email protected]>

Updated the first installation instructions

237dac7

Signed-off-by: JesusSilvaUtrera <[email protected]>

Updates CHANGELOG.

83ab570

Signed-off-by: Franco Cipollone <[email protected]>

0.2.0

ba082e1

Updates README.md

07b36c6

Signed-off-by: Franco Cipollone <[email protected]>

Adds reference to andino_rmf repo (#263)

4ec1ba4

Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Include robot assembly (#267)

f149d42

* Added all necessary changes to the README Signed-off-by: JesusSilvaUtrera <[email protected]> * Removed a blank line Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]>

Merge branch 'jsilva/change_docker_files_for_Jazzy' of github.com:Jes…

7fd2429

…usSilvaUtrera/andino into jsilva/change_docker_files_for_Jazzy

JesusSilvaUtrera closed this Sep 16, 2024

JesusSilvaUtrera deleted the jsilva/change_docker_files_for_Jazzy branch September 16, 2024 12:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jsilva/change docker files for jazzy #260

Jsilva/change docker files for jazzy #260

JesusSilvaUtrera commented Jul 17, 2024 •

edited by francocipollone

Loading

JesusSilvaUtrera commented Jul 17, 2024

francocipollone left a comment

francocipollone Aug 14, 2024

JesusSilvaUtrera Sep 3, 2024

francocipollone Aug 14, 2024

JesusSilvaUtrera Sep 3, 2024

francocipollone Aug 14, 2024

JesusSilvaUtrera Sep 3, 2024

JesusSilvaUtrera commented Sep 16, 2024

		# chown -R "$USER" ${REPOSITORY_FOLDER_PATH}/.build
		# chown -R "$USER" ${REPOSITORY_FOLDER_PATH}/.install

		WORKSPACE_SRC_CONTAINER=/home/ubuntu/ws/src/$REPOSITORY_FOLDER_NAME
		WORKSPACE_ROOT_CONTAINER=/home/ubuntu/ws

Jsilva/change docker files for jazzy #260

Jsilva/change docker files for jazzy #260

Conversation

JesusSilvaUtrera commented Jul 17, 2024 • edited by francocipollone Loading

🎉 New feature

Summary

Test it

Checklist

JesusSilvaUtrera commented Jul 17, 2024

francocipollone left a comment

Choose a reason for hiding this comment

francocipollone Aug 14, 2024

Choose a reason for hiding this comment

JesusSilvaUtrera Sep 3, 2024

Choose a reason for hiding this comment

francocipollone Aug 14, 2024

Choose a reason for hiding this comment

JesusSilvaUtrera Sep 3, 2024

Choose a reason for hiding this comment

francocipollone Aug 14, 2024

Choose a reason for hiding this comment

JesusSilvaUtrera Sep 3, 2024

Choose a reason for hiding this comment

JesusSilvaUtrera commented Sep 16, 2024

JesusSilvaUtrera commented Jul 17, 2024 •

edited by francocipollone

Loading