Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for runtime control of rhs TAG #270

Open
SamuelCupp opened this issue Mar 26, 2024 · 0 comments
Open

Allow for runtime control of rhs TAG #270

SamuelCupp opened this issue Mar 26, 2024 · 0 comments

Comments

@SamuelCupp
Copy link
Contributor

Since the pairing of RHS variables with their evolution variables is now done via a tag, it would be helpful for this to be controllable at runtime.

For an example use case, the Avec variables in HydroBaseX should be usable as the evolution variables directly instead of requiring the data to be copied into a new variable first. This requires that the rhs tag be controllable via a parameter, and that the thorns using this tag read it properly at runtime based on the parameter. The basic idea of this is already implemented (see e.g. prolongation_type in the original HydroBase thorn), but I don't know if this mechanism is fully supported by the code that uses this tag.

At the least, this would require adding a runtime parameter for controlling the rhs variable for the Avec groups, as well as the ability to turn it off if A isn't being evolved. The option to turn it off is almost certainly not implemented in the current rhs infrastructure, so this capability would need to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant