Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown items are not moving to the next tab index due to stopPropagation #911

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

sravichandran-eightfold
Copy link
Collaborator

SUMMARY:

There was a bug introduced recently to make the focus of the dropdown sticky.
This regressed any input fields to be stuck on first focus

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-116631

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  1. Go to storybook
  2. Check the Dropdown Advanced
  3. Make sure you can tab into the checkbox
Screen.Recording.2024-11-13.at.9.51.50.AM.mov

Copy link

codesandbox-ci bot commented Nov 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (3f673dd) to head (af76511).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   84.59%   84.61%   +0.01%     
==========================================
  Files        1100     1100              
  Lines       20492    20488       -4     
  Branches     7748     7748              
==========================================
- Hits        17336    17335       -1     
+ Misses       3069     3066       -3     
  Partials       87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sravichandran-eightfold sravichandran-eightfold merged commit d571817 into main Nov 13, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants