Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formError: fixed focus not moving to 1st required input on error #889

Conversation

rmotwani-c-eightfold
Copy link
Contributor

SUMMARY:

fixed an issue with focus not moving to 1st required input on error.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

Jira task - https://eightfoldai.atlassian.net/browse/ENG-107285

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • pull branch down locally and start storybook (yarn storybook)
  • with screen reader on, goto form component.
  • Submit an empty form with required fields and observe that focus is moving or getting activated on the 1st empty input required field.

Copy link

codesandbox-ci bot commented Sep 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

src/components/Form/Hooks/useForm.ts Outdated Show resolved Hide resolved
@rmotwani-c-eightfold rmotwani-c-eightfold merged commit 9db65ad into EightfoldAI:main Sep 9, 2024
3 of 4 checks passed
jhoward-eightfold added a commit that referenced this pull request Sep 9, 2024
…#889)

* fix: formError: fixed focus not moving to 1st required input on error

* Update src/components/Form/Hooks/useForm.ts

Co-authored-by: Jeff Howard <[email protected]>

---------

Co-authored-by: Jeff Howard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants