You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many modal instances use either "Close modal" or "Close panel" as the closeButtonAriaLabelText prop for Modal component. Since the developer is usually expected to specify the onClose functionality and not different props for close button, we can also provide the aria label by default (similar to the icon props for close button). Furthermore, it would bring consistency in aria label across different modals.
The closeButtonAriaLabelText prop is available. Providing a default prop is only effective if the Locale is properly passed to the ConfigProvider as documented in Storybook. Given this is not the case in all but 5 of Eightfold's applications, I suggest using your own localized string
Many modal instances use either "Close modal" or "Close panel" as the closeButtonAriaLabelText prop for Modal component. Since the developer is usually expected to specify the onClose functionality and not different props for close button, we can also provide the aria label by default (similar to the icon props for close button). Furthermore, it would bring consistency in aria label across different modals.
PR for the fix
The text was updated successfully, but these errors were encountered: