Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fadein: add fadein component #737

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Add FadeIn component
  • Add its Unit Tests
  • Add its story
fadein.mp4

JIRA TASK (Eightfold Employees Only):

ENG-62741

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the FadeIn component behaves as expected.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 096aad2:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/components/FadeIn/FadeIn.tsx 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@dkilgore-eightfold dkilgore-eightfold merged commit 32064df into EightfoldAI:main Oct 21, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants