Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: table: add rowExpandDisabled prop #731

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Adds rowExpandDisabled prop to disable expandable rows if needed via record.
  • Updates expand icon button styles and adds a disabled attribute
  • Adds some missing types
  • Adds a unit test
  • Updates Expandable row stories
disableExpandableRow.mp4

JIRA TASK (Eightfold Employees Only):

ENG-67552

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Table Expand Row stories behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c981259:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/components/Table/Internal/Body/BodyRow.tsx 98.24% <100.00%> (+0.06%) ⬆️
src/components/Table/Internal/Body/index.tsx 100.00% <ø> (ø)
src/components/Table/Internal/Hooks/useColumns.tsx 96.90% <100.00%> (+0.24%) ⬆️
src/components/Table/Internal/OcTable.tsx 98.41% <ø> (ø)
src/components/Table/Table.tsx 78.36% <ø> (ø)
src/components/Table/ExpandIcon.tsx 91.66% <83.33%> (-8.34%) ⬇️
...components/Table/Internal/Utilities/expandUtil.tsx 94.73% <80.00%> (-5.27%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@dkilgore-eightfold dkilgore-eightfold merged commit b0b7640 into EightfoldAI:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants