-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insufficient selections for project #1
Comments
Hey Kalllie! I'm having a bit of trouble understanding. The script shouldn't care if there aren't enough people to satisfy the vacancies, it should make sure that each person is assigned not necessarily that all vacancies are filled. Are you referring to the scenario where there are more people than there are vacancies? I just tried this, but could not get it to hang. Some example data to evoke this defect would be very helpful. Thank you |
Sure I can clarify! |
OooOoh I see what happened. Thank you for the clarification. I'll work on fixing that case here soon. |
You're awesome! |
So, looking into this more, it seems like the underlying problem is an infinite loop within the implementation of Munkres that I'm consuming. It looks like someone else also found this bug and posted this issue. I've committed a temporary change a76127e which avoids the usage of their DISALLOWED functionality until they can fix the issue. The case you described should now work. A related change is that there is now a concept of "forced assignment," which occurs in the rare case when it is impossible to assign someone to any of their choices. It will indicate "forced assignment" as the pick number in the console output if this occurs. |
Right now, no. There is currently no concept of a person's "language preference" only their "project preferences." This could be a future enhancement, and if you want this, please log it separately. For now, though, I'd advise you to just avoid forced assignments by telling associates they can list as many picks as they want (not just 3 or 5 or whatever you currently do). The script accepts arbitrary amounts of picks. P.S. I just added a console warning for when a forced assignment occurs. |
When selections are made and there are not enough to satisfy the vacancies the script perpetually runs instead of giving the user information about what went wrong. Would like an option to randomly assign to another project of same language or to update the selections myself.
The text was updated successfully, but these errors were encountered: