Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimeo/psalm support #85

Closed
MacFJA opened this issue Aug 19, 2017 · 4 comments
Closed

vimeo/psalm support #85

MacFJA opened this issue Aug 19, 2017 · 4 comments

Comments

@MacFJA
Copy link
Contributor

MacFJA commented Aug 19, 2017

The project https://github.com/vimeo/psalm give good insight about code quality and possible misconception.

It would be great if phpqa have it in its available tools

@MacFJA
Copy link
Contributor Author

MacFJA commented Aug 27, 2017

I started to write the code for this feature.

Right now I have some trouble to get the number of errors (I open a PR on vimeo/psalm#206 to solve this)

@zdenekdrahos
Copy link
Member

Good job, @MacFJA.

How do you plan to use --analyzedDirs/--ignoredDirs/--ignoredFiles in projectFiles?
I would prefer similar process like in phpstan:

  1. load xml config file from .phpqa.yml
  2. update projectFiles save a new xml file in --buildDir/psalm-phpqa.xml

BTW you can develop the psalm support even without XML and number of errors. If you use OutputMode::RAW_CONSOLE_OUTPUT then CLI output is used in report.

@MacFJA
Copy link
Contributor Author

MacFJA commented Sep 3, 2017

I exactly use what is done on phpstan: If no config is provided in the .phpqa.yml, I generate a config file base on --analyseDirs, --ignoredDirs and --ignoredFiles.

My code is ready, just waiting my PR to be validated ( Here some screenshot of the rendering Report HTML - 1, Report HTML - 2)

@zdenekdrahos
Copy link
Member

@MacFJA: the code has been released in version 0.3.55.
I'm already looking forward to a phpqa PR. Screenshots look great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants