Frame.Focus.Text is now defined in specific color config #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I completely forgot about the Titlebar Accent stuff, good catch. I'd recommend keeping orange's Accent.Text white for now though. There's a lot of instances where black text would go with white icons, which doesn't look too great. Plus the titlebar text is actually an icon when the back button is showing (oh boy gross hacks) and it would seem weird for it to change colors when that button appears and disappears. |
|
it can be available that the Navigation Hamburger Button actually work like a real UWP? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed, because in Windows 10, certain colors (orange) have their titlebar text in black. While the way this has been implemented seems convoluted, it's necessary since it needs to be changed to white if the titlebar is set to black. The only issue now is that symbols (e.g. "Minimize", "Maximize",...) still stay white.
This PR also fixes the Accent.Text value in orange.styles to be black.