Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this bug when working on the tools section. In the "Who's online" does a query to
/api/v1/misc/active
which has a formula for how many active character in the last 14 days. If there is an error or there is no active characters in the last 14 days it was supposed to send to the client an error. However, the function was returning the string to the simple cache setter. Because the return set the cache and not response to the client the server crashes since we are setting the header again when we send the cache.We never see this on production or the test server because we always have someone who has logged on in the last 14 days. To fix this I just have it return a string of
0
to the cache.