This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
switch code highlighter to rehype-pretty-code #10172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
eddiejaoude
reviewed
Jan 24, 2024
| import createMDX from "@next/mdx"; | ||
| import withPWA from "next-pwa"; | ||
| import runtimeCaching from "next-pwa/cache.js"; | ||
|
|
||
| const isProduction = process.env.NODE_ENV === "production"; | ||
| //const isProduction = process.env.NODE_ENV === "production"; |
There was a problem hiding this comment.
Is this no longer needed? Can it be removed?
There was a problem hiding this comment.
It is only referenced by a line in the pwaConfig section which is commented out.
I commented it out to get rid of the unused variable squiggly, but left it in case the config line gets uncommented.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
Switch code highlighter from
remark-prismtorehype-pretty-codeReasons:
remark-prismhas not been updated in several yearsrehype-pretty-codeis recommended in the Nextjs documentationDocumentation of new highlighter.
Check List (Check all the applicable boxes)