Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload the original code of PG model #276

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

upload the original code of PG model #276

wants to merge 9 commits into from

Conversation

DanyangYu
Copy link
Contributor

@DanyangYu DanyangYu commented Dec 31, 2024 •
edited
Loading

Description

fix #275

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and
    linter    , below the pull request, are
    successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully, see tests.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@DanyangYu DanyangYu linked an issue Dec 31, 2024 that may be closed by this pull request
Integration of plant growth module into STEMMUS-SCOPE (STEMMUS-SCOPE-PG) #275
Open
DanyangYu
DanyangYu commented Dec 31, 2024
View reviewed changes
Copy link
Contributor Author

@DanyangYu DanyangYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All global variables have been removed. Please review the revisions.

@Crystal-szj Crystal-szj self-assigned this Jan 2, 2025
Crystal-szj
Crystal-szj requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Crystal-szj Crystal-szj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DanyangYu, thank you very much for your efforts on the PG model. I left some suggestions for your reference. After you resolve all conversations, I'll create a new execute file for this branch.

src/+init/setBoundaryCondition.m Show resolved Hide resolved
example_data/input_soilLayThick.csv Show resolved Hide resolved
src/+wofost/cropgrowth.m Outdated Show resolved Hide resolved
src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crystal-szj Crystal-szj Crystal-szj requested changes

@Yunfei-Wang1993 Yunfei-Wang1993 Yunfei-Wang1993 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@Crystal-szj Crystal-szj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration of plant growth module into STEMMUS-SCOPE (STEMMUS-SCOPE-PG)
3 participants
@DanyangYu @Yunfei-Wang1993 @Crystal-szj