Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate encoder cnn/mlp keys from decoder cnn/mlp keys #75

Closed
belerico opened this issue Aug 11, 2023 · 0 comments · Fixed by #81
Closed

separate encoder cnn/mlp keys from decoder cnn/mlp keys #75

belerico opened this issue Aug 11, 2023 · 0 comments · Fixed by #81
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@belerico
Copy link
Member

Right now the multi-enocder/decoder shares the same cnn/mlp keys they encodes/decodes, i.e. the encoded keys correspond to the decoded keys. There can be situations in which someone may want to encode something that doesn't need to be decoded. It would be better to separate the encoder keys from the decoder ones

@belerico belerico added enhancement New feature or request help wanted Extra attention is needed labels Aug 16, 2023
@belerico belerico mentioned this issue Sep 6, 2023
4 tasks
@belerico belerico linked a pull request Sep 6, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant